Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sponge is not implemented for true SDC #3017

Open
zingale opened this issue Jan 8, 2025 · 1 comment
Open

sponge is not implemented for true SDC #3017

zingale opened this issue Jan 8, 2025 · 1 comment
Labels

Comments

@zingale
Copy link
Member

zingale commented Jan 8, 2025

For true-SDC, the sponge does not work since construct_old_sponge_source is a no-op. This is because we treat the sponge implicitly with the CTU evolution, but SDC always needs the source at the time of the quadrature node, and therefore only ever calls the old time sources.

@zingale zingale added the sdc label Jan 8, 2025
@zingale
Copy link
Member Author

zingale commented Jan 9, 2025

the way we implement the Sponge in Castro is essentially that of Almgren et al. 2008 (Maestro paper III), which is an implicit update to the velocity:

U^new = U^old - dt kappa f U^new

this is equivalent to doing:

U^new = U^old / (1 + dt kappa f)

this is also referenced in the original Castro paper (Almgren et al. 2010) and the wdmerger paper (Katz et al. 2016).

For a MOL integration, we can't really do the implicit update, since we are just computing the advective terms at a particular instance in time. Instead, we should just implement a sponge source in these cases that has the form:

S_sponge = - kappa f U

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant