Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace setVal's so that FArrayBox's are filled on the GPU #104

Open
harpolea opened this issue Oct 11, 2019 · 1 comment
Open

Replace setVal's so that FArrayBox's are filled on the GPU #104

harpolea opened this issue Oct 11, 2019 · 1 comment
Labels

Comments

@harpolea
Copy link
Member

Currently, all setVal calls acting on FArrayBox's are performed on the host. In profiling of code running on the GPU, it can be seen that this can result in considerable copying of data to/from the host and device, and means that this operation can take a non-negligible amount of time (considering all it's doing is filling arrays with zeros).

Such calls should be replaced e.g. with an AMREX_PARALLEL_FOR, as was done here AMReX-Astro/Castro@93b7b6f

@harpolea harpolea added the GPU label Oct 11, 2019
@zingale
Copy link
Member

zingale commented May 3, 2024

this may no longer be an issue. setVal operates on a GPU now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants