-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use amu instead of 1/n_A for m_nucleon in gamma_law #1240
Conversation
I'm fine with this, but I want to run it though our suites, since there will be a lot of small changes. But I think it is a good idea to sync up with the standard constants here. |
Sounds good. We may also need to update the reference solution for the test that fails. |
This looks good to me. @zingale do we need to update the reference solution for the |
sorry, I will do that. I'll try to get this done today and do a PR to your PR |
There's a PR to @psharda 's PR, that once merged will fix the EOS test. Then this is good to merge. |
@psharda said that you were trying to understand something before merging this |
update eos_cell unit test benchmark
This PR should pass all tests now, and will be ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@zingale are you happy with this in its current form? It's ready to go on our end. |
Is this what we'd want to do (for gamma_law)?