[FEAT] 7주차 필수 과제 #14
Open
[FEAT] 7주차 필수 과제 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinseoSONG
reviewed
Dec 19, 2024
Comment on lines
+11
to
+13
| fun Context.serverToast(message: String? = "") { | ||
| Toast.makeText(this, message, Toast.LENGTH_SHORT).show() | ||
| } |
Comment on lines
+15
to
+17
| sealed interface HomeSideEffect : UiSideEffect | ||
|
|
||
| sealed class HomeEvent : UiEvent |
There was a problem hiding this comment.
효빈님께도 드린 질문인데, 만약 sideeffect와 event가 없더라도 만들어두는게 좋을까요 ? 저는 안만들어서 ..
Comment on lines
+49
to
+55
| LoadState.Idle -> {} | ||
|
|
||
| LoadState.Loading -> {} | ||
|
|
||
| LoadState.Success -> MyProfileScreen(myUiState = uiState) | ||
|
|
||
| LoadState.Error -> {} |
There was a problem hiding this comment.
Idle은 뭘까요 ! 그리고 비어있는 건 빈 상태로 두는게 좋은지, 애초에 추가하지 않는게 좋은지 궁금합니다 !
|
|
||
|
|
||
| @ExperimentalPermissionsApi | ||
| @OptIn(ExperimentalPermissionsApi::class) |
There was a problem hiding this comment.
이 어노테이션을 추가하신 이유가 무엇인가요?? 어떤 역할을 하는 어노테이션일까요?
Comment on lines
+48
to
+56
| when (uiState.loadState) { | ||
| LoadState.Idle -> {} | ||
|
|
||
| LoadState.Loading -> {} | ||
|
|
||
| LoadState.Success -> MyProfileScreen(myUiState = uiState) | ||
|
|
||
| LoadState.Error -> {} | ||
| } |
There was a problem hiding this comment.
success를 제외하면 다 빈 코드인데 else를 사용하지 않고 다 명시해준 이유가 무엇인가요????
Comment on lines
+44
to
+49
| setEvent( | ||
| MyProfileContract.ProfileEvent.FetchUserHobby( | ||
| loadState = LoadState.Loading, | ||
| userHobby = currentState.hobby | ||
| ) | ||
| ) |
There was a problem hiding this comment.
event를 뷰모델 내에서도 수정하시네요!! 저는
event = 사용자의 intent -> 뷰에서만 변경됨!!
이렇게 생각했었는데 뷰모델 내에서도 setEvent를 해도 괜찮나요??(진짜 모름)
jihyunniiii
reviewed
Dec 25, 2024
Comment on lines
-152
to
+166
| HomeScreen() | ||
| HomeRoute() |
| } | ||
|
|
||
| when (uiState.loadState) { |
There was a problem hiding this comment.
각 상태에 따라 적절한 화면을 보여주는 것이 좋아보여요!
| import androidx.compose.material.icons.filled.CheckCircle | ||
|
|
||
| object SignUpImage{ | ||
| val EXTRA_SIGNUP_IMAGE_LIST = listOf( |
There was a problem hiding this comment.
immutable이나 stable하게 선언하면 좋을 것 같네요 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
9pr.mp4
Uncompleted Tasks 😅
To Reviewers 📢
아직 에러처리와 코리 적용을 못했습니다 시험이끝나고 돌아와서 바로 해보겠습니다 ㅠㅠ