Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add maintainers for ROS 2 or transfer of ownership of ROS 2 to ethz-asl #413

Open
6 of 12 tasks
Ryanf55 opened this issue Jan 20, 2024 · 2 comments
Open
6 of 12 tasks
Labels
ros2 Affects ROS 2
Milestone

Comments

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Jan 20, 2024

Hello,

I would like to request to be added as a maintainer for the ROS 2 branches of grid_map.

Option 1: Add me as a maintainer
Option 2: Endorse having the ROS 2 port at https://github.com/ethz-asl/grid_map, and direct users there for pull requests.
I'm open to other options.

I am currently maintaining a few related libraries in ROS 2 like grid_map_geo, which heavily depends on grid_map.

While this repository is maintained for ROS 1, the same is not as clear for ROS 2. By opening up the library to more maintainers, this will alleviate some of the open issues and PR's for documentation and building the repo. Without this, it's become difficult to use grid_map in ROS 2, especially as the ROS 2 branch becomes further out of date with master.

Furthermore, the branch structure is not common practice for ROS 2, there is no policy or information on how to contribute to which branch. Obviously, foxy is now EOL, so those PR's may need forward-ported to a LTS release such as humble.

For clarity, here is a list of issues affecting ROS 2 that have not been addressed:

As part of maintaining grid_map_geo, I would take the following approach, in chronological order:

  • start using labels to categorize issues and PR's with whether they are ROS 1 or ROS 2
  • Simplify and document the branching strategy to only use rolling, iron and humble
  • Close anything related to EOL ROS distritions that can't be reproduced in humble
  • Create an issue template such that issue reporters are required to fill out a ROS distribution
  • Prioritize compilation issues first, then address the reported memory leaks or compile warnings that cause undefined behavior
  • Develop a maintenance plan and improve automatition
  • Define a strategy to merge changes from master into ROS 2 branches
  • Set a goal for a release
  • Release binaries for rolling, iron and humble
  • Develop future maintenance plan
@Ryanf55 Ryanf55 changed the title Request to add maintainers for ROS 2 or transfer of ownership of ROS 2 to ethz-asl or Request to add maintainers for ROS 2 or transfer of ownership of ROS 2 to ethz-asl Jan 20, 2024
@maximilianwulf
Copy link
Collaborator

Thanks a lot for the request. You should be maintainer now.

@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Jan 31, 2024

Thanks! All issues in the above list now have the ros2 label.

@Ryanf55 Ryanf55 added the ros2 Affects ROS 2 label Jan 31, 2024
@Ryanf55 Ryanf55 added this to the 2.2.0 milestone Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ros2 Affects ROS 2
Projects
None yet
Development

No branches or pull requests

2 participants