forked from vernon-gant/cleancode
-
Notifications
You must be signed in to change notification settings - Fork 0
/
07_oop_interfaces.txt
53 lines (34 loc) · 1.55 KB
/
07_oop_interfaces.txt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
3.1
1) Customer(String name, String email, String password, String phone, String address, int age) {
RandomGenerator random = new RandomGenerator();
random.randomIDGen();
this.name = name;
this.userID = random.getRandomNumber();
this.email = email;
this.password = password;
this.phone = phone;
this.address = address;
this.age = age;
this.flightsRegisteredByUser = new ArrayList<>();
this.numOfTicketsBookedByUser = new ArrayList<>();
}
I would put all parameters into a separate class for more cohesion, call it CustomerDetails and then create a static factory method FromDeatils
public static Customer FromDetails(CustomerDetails details) {...}
2) Position(int x, int y); Position(int x); Position(int y)
During our oop course we had to programm different console games and this class was everywhere.
Now I know how all my overloaded constructors should look like :)
public static Position OnXAxis(int x);
public static Position OnYAxis(int x);
public static Position AtCoordinates(int x);
3) public QueueConnector(Queue<T> qnew);
public static QueueConnector fromQueue(Queue<T> qnew) would increase readability
3.2
1) public interface IFlying
I would rename it to Flyable to emphisize the ability to fly and not just the action.
2) public interface Messageable {
void sendMessage();
String getMessage();
}
Messageable is too weird, Communicator seems to be better
3) public interface Cardable {}
I think for a poker game having a Card interface could be more concise.