Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-duplicate the retro definitions? #14

Open
Artoria2e5 opened this issue May 25, 2024 · 0 comments
Open

De-duplicate the retro definitions? #14

Artoria2e5 opened this issue May 25, 2024 · 0 comments

Comments

@Artoria2e5
Copy link
Member

We have a lot of duplication in the "retro" arch definitions when it comes to OPTI args; just grepping for # Retro: should reveal them all. The consensus seems to be the following, more or less:

# Retro: Overriding mainline definitions, and take more interest in reducing code size.
CFLAGS_COMMON_OPTI=('-Os' '-ffunction-sections' '-fdata-sections')
LDFLAGS_COMMON_OPTI=('-Wl,--gc-sections')
# Retro: Also disabling -ftree-vectorization which could potentially enlarge code size.
CFLAGS_GCC_OPTI=('-fira-loop-pressure' '-fira-hoist-pressure')

Maybe we can get a new file called arch/_retro.sh and just do load_strict "$AB/arch/_retro.sh" in these files, where it applies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant