You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some build scripts in ABBS assumes CFLAGS_COMMON_ARCH exists1, but that's not the case for every architecture.
autobuild4 supports 20 actual architectures now, but only 16 of them define CFLAGS_COMMON_ARCH.
loongarch64.sh doesn't define CFLAGS_COMMON_ARCH, but defines CFLAGS_GCC_ARCH and CFLAGS_CLANG_ARCH separately, which should be outdated as of the writing, since LLVM 18 already supports LSX23?
loongson3.sh does the same thing as LA64, though I think Clang supports -mxgot4 for a long time?
ppc64el.sh doesn't define CFLAGS_COMMON_ARCH but defines both CFLAGS_GCC_ARCH and CFLAGS_CLANG_ARCH as the exact same string.
For some history on this variable: in early 2017, when @MingcongBai add it to the build script, there were just 8 architectures supported by autobuild3, and all of them had CFLAGS_COMMON_ARCH defined1.
Some build scripts in ABBS assumes
CFLAGS_COMMON_ARCH
exists1, but that's not the case for every architecture.autobuild4 supports 20 actual architectures now, but only 16 of them define
CFLAGS_COMMON_ARCH
.loongarch64.sh
doesn't defineCFLAGS_COMMON_ARCH
, but definesCFLAGS_GCC_ARCH
andCFLAGS_CLANG_ARCH
separately, which should be outdated as of the writing, since LLVM 18 already supports LSX23?loongson3.sh
does the same thing as LA64, though I think Clang supports-mxgot
4 for a long time?ppc64el.sh
doesn't defineCFLAGS_COMMON_ARCH
but defines bothCFLAGS_GCC_ARCH
andCFLAGS_CLANG_ARCH
as the exact same string.riscv64.sh
has noCFLAGS*
definition.Should we...
CFLAGS_COMMON_ARCH
exist on every architecture, assigning at least some common flags to them for architectures like LoongArch 64 and Loongson 3?CFLAGS_COMMON_ARCH
.Also it might be time to review all these flags, I think this is a blocker of AOSC-Dev/aosc-os-abbs#5863.
Footnotes
https://github.com/AOSC-Archive/aosc-os-core/commit/2b5ecbaedd4c8cec8811d9692f1341ec63f82f54 ↩
https://releases.llvm.org/18.1.0/tools/clang/docs/ReleaseNotes.html#loongarch-support ↩
https://releases.llvm.org/18.1.0/tools/clang/docs/ClangCommandLineReference.html#cmdoption-clang-mlsx ↩
https://releases.llvm.org/18.1.0/tools/clang/docs/ClangCommandLineReference.html#cmdoption-clang-mxgot ↩
The text was updated successfully, but these errors were encountered: