We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Note: ArMarkerControls is a dervied class from ArBaseControls This happens because i implemented the code in this way
AR.js-threejs/src/ArBaseControls.ts
Lines 3 to 14 in 9c8e08b
const ArBaseControls = function (object3d) { this.id = ArBaseControls.id++; this.object3d = object3d; this.object3d.matrixAutoUpdate = false; this.object3d.visible = false; // Events to honor // this.dispatchEvent({ type: 'becameVisible' }) // this.dispatchEvent({ type: 'markerVisible' }) // replace markerFound // this.dispatchEvent({ type: 'becameUnVisible' }) }; ArBaseControls.id = 0;
https://github.com/AR-js-org/AR.js/blob/be7c9083df5a651c2ab978ddd7c1a33409c4d40b/three.js/src/threex/threex-arbasecontrols.js#L3-L16 I think this is a bad idea. The _id (should be re-named id) should simply be incremented and not added by the static id property. I will fix this.
_id
id
The text was updated successfully, but these errors were encountered:
fix for issue #5
881d017
- this need to be tested adding more than one marker.
5413494
kalwalt
No branches or pull requests
Note: ArMarkerControls is a dervied class from ArBaseControls
This happens because i implemented the code in this way
AR.js-threejs/src/ArBaseControls.ts
Lines 3 to 14 in 9c8e08b
original AR.js code here:
https://github.com/AR-js-org/AR.js/blob/be7c9083df5a651c2ab978ddd7c1a33409c4d40b/three.js/src/threex/threex-arbasecontrols.js#L3-L16
I think this is a bad idea. The
_id
(should be re-namedid
) should simply be incremented and not added by the static id property. I will fix this.The text was updated successfully, but these errors were encountered: