Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove colons in log #8

Open
benjamin051000 opened this issue Mar 30, 2023 · 3 comments
Open

Remove colons in log #8

benjamin051000 opened this issue Mar 30, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@benjamin051000
Copy link
Member

The : is unnecessary. These logs are never going to be read by a human, so why make them human-readable?

The example write_log.txt from EE's website is 2,301,150 lines, with 63,876,645 characters. One ':' per line is 2,301,150 colons throughout the file.

By removing this, we save about 3.6% file space. Not much, but it's effortless to achieve.

@benjamin051000 benjamin051000 added enhancement New feature or request good first issue Good for newcomers labels Mar 30, 2023
benjamin051000 added a commit that referenced this issue Mar 30, 2023
@benjamin051000
Copy link
Member Author

Other things could also be removed:

  • space between time and unit
  • space between unit and hysnc
  • space between hsync and vsync

@benjamin051000
Copy link
Member Author

We still sorta need the spaces between the r, g, b signals since they are variable-width and we don't necessarily have an easy way to record what their widths are. Unless in VHDL you can do something like

write(line_el, red'length);

If this is possible, then we can remove those spaces, too by including a line at the top that specifies the lengths of r, g, and b.

@benjamin051000
Copy link
Member Author

Unfortunately, removing more spaces may incur a runtime cost, as we may need regex to parse it rather than a simple string split.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant