Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider to protect include "RTE_components.h" with _RTE_ #205

Open
ReinhardKeil opened this issue Nov 18, 2024 · 2 comments · May be fixed by #206
Open

Consider to protect include "RTE_components.h" with _RTE_ #205

ReinhardKeil opened this issue Nov 18, 2024 · 2 comments · May be fixed by #206

Comments

@ReinhardKeil
Copy link
Contributor

ReinhardKeil commented Nov 18, 2024 •
edited
Loading

Consider adding

#ifdef _RTE_

to https://github.com/ARM-software/CMSIS_6/blob/main/CMSIS/RTOS2/Source/os_systick.c#L28C1-L28C28

See #200 for reference
@JonatanAntoni
Copy link
Member

@RobertRostohar, any concerns?

@RobertRostohar
Copy link
Contributor

We should add the #ifdef _RTE_ to be consistent and in line with explanations in #200.

JonatanAntoni added a commit that referenced this issue Nov 19, 2024
@JonatanAntoni
Guard include of RTE_Components.h with presence of _RTE_
d1fc5e9 
Fixes #205
@JonatanAntoni JonatanAntoni linked a pull request Nov 19, 2024 that will close this issue
Open
JonatanAntoni added a commit that referenced this issue Nov 19, 2024
@JonatanAntoni
Guard include of RTE_Components.h with presence of _RTE_
c44f774 
Fixes #205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Guard include of RTE_Components.h with presence of _RTE_ ARM-software/CMSIS_6
3 participants
@ReinhardKeil @RobertRostohar @JonatanAntoni