Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check pinata downloads (and extensions) #339

Closed
royscheeren opened this issue Oct 29, 2024 · 3 comments
Closed

Check pinata downloads (and extensions) #339

royscheeren opened this issue Oct 29, 2024 · 3 comments
Assignees
Labels
quality Important items to increase product quality.

Comments

@royscheeren
Copy link
Contributor

royscheeren commented Oct 29, 2024

reminder to check the results of #334

@royscheeren royscheeren added this to the ENVITED User Meeting milestone Oct 29, 2024
@jdsika
Copy link
Contributor

jdsika commented Oct 29, 2024

CID v0 webinterface

So, by default, uploads return a v0 CID. The only way you can change this is via the API, not in the web app. I apologize for the inconvenience.

You can change them with pinataOptions, as outlined here

Double file extension

What’s happening here is actually expected behavior based on the way the file name is saved. When you name your file as "file.json" or "image.png" during upload, Pinata saves it exactly as is, unless you change it upon upload.

When you go to download the file, the system will keep that original file name, but since your local system recognizes the file type, it adds the extension again automatically. So, "file.json" downloads as "file.json.json" because it's applying the .json extension to the full file name "file.json."

To avoid this, you can try naming your files without the extension in the actual name, like "file" or "image" instead. This way, when you download it, only one extension will be added.

@jdsika jdsika added the quality Important items to increase product quality. label Nov 8, 2024
@jdsika
Copy link
Contributor

jdsika commented Nov 19, 2024

@royscheeren make sure to check if Pinata allows to specifiy the parameters for the CID v1 calculation in order to replicate it with the local function. Compare local CID generation with return value from Pinata as sanity check.

@jdsika
Copy link
Contributor

jdsika commented Dec 6, 2024

Confirmed 06/12/2024

@jdsika jdsika closed this as completed Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality Important items to increase product quality.
Projects
None yet
Development

No branches or pull requests

2 participants