Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constructor of SonarLintEngine should not produce any side-effects #716

Open
algomaster99 opened this issue Feb 2, 2022 · 0 comments
Open

Constructor of SonarLintEngine should not produce any side-effects #716

algomaster99 opened this issue Feb 2, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@algomaster99
Copy link
Member

Reference: #696 (comment)

We recreate the analysis engine whenever we fetch the singleton instance of SonarLintEngine. That's bad for two reasons.

  1. There should not be any side-effect when we fetch the singleton instance.
  2. Recreation is necessary for tests so we should instead refactor our tests to invoke recreateAnalysisEngine before each test case.
@algomaster99 algomaster99 changed the title Constructor of SonarLint engine should not produce any side-effects Constructor of SonarLintEngine should not produce any side-effects Feb 2, 2022
@algomaster99 algomaster99 added the enhancement New feature or request label Feb 2, 2022
@algomaster99 algomaster99 added the good first issue Good for newcomers label Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
No milestone
Development

No branches or pull requests
1 participant
@algomaster99