Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Names of anonymous classes cause issues #86

Open
slarse opened this issue Mar 27, 2020 · 3 comments
Open

Names of anonymous classes cause issues #86

slarse opened this issue Mar 27, 2020 · 3 comments
Labels
bug Something isn't working might be fixed?

Comments

@slarse
Copy link
Collaborator

slarse commented Mar 27, 2020

The names of anonymous functions are integers, and these are arbitrary. However, Spork treats them as if they have meaning for the anonymous function, which can cause content conflicts on anonymous functions even if there are none.

A quick fix for this is to simply not resolve the names of anonymous functions. The downside of that is that there could end up being multiple anonymous functions in the tree with the same name, and I'm uncertain of what effects that may have.
@slarse slarse added the bug Something isn't working label Mar 27, 2020
slarse added a commit that referenced this issue Mar 29, 2020
@slarse
[fix] Don't resolve name of anonymous class #86
755b27b 
Not necessarily a complete solution, this might cause issues
@slarse
Copy link
Collaborator Author

slarse commented Mar 29, 2020

This may have been fixed by 755b27b, but I'm really not sure

@slarse
Copy link
Collaborator Author

slarse commented Mar 29, 2020

As it turns out, just not resolving the name causes crashes when the type of an anonymous class is matched to any other type reference. So we must resolve the name (but we can fake it).

slarse added a commit that referenced this issue Mar 29, 2020
@slarse
[fix] Resolve name of anonymous class to empty string #86
6b0c63b
slarse added a commit that referenced this issue Mar 29, 2020
@slarse
[fix] Resolve name of anonymous class to empty string #86
e88f2c3
@slarse slarse changed the title Names of anonymous functions cause issues Names of anonymous classes cause issues Mar 30, 2020
@slarse slarse mentioned this issue Mar 30, 2020
Closed
@slarse
Copy link
Collaborator Author

slarse commented Mar 30, 2020

Lo and behold, this did result in bug #93

Current solution is to resolve names to "0" instead, such that anonymous classes are still identified as anonymous. Fixed in d4a42b4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working might be fixed?
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@slarse