Restructuring Team Page #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamkorde
requested changes
May 24, 2021
There was a problem hiding this comment.
Mostly looks good.
- Revert back the images.
- The cards have links to Facebook and LinkedIn profiles of the team members. Can you collect the data and it, so that we can have the links working. A google form will be helpful for data collection. The data for all the Y20's can be collected using the same form.
| <Col md="2"></Col> | ||
| <Col md="5" className="text-center"> | ||
| <h3 className="mt-5 mb-3 small-heading mb-2">Business</h3> | ||
| <img src={business} className=" w-100"></img> |
There was a problem hiding this comment.
We would like to have some graphic images for each subsystem section. Do not remove any images.
There was a problem hiding this comment.
@ritam2358 once you have addressed a particular issue on which the reviewer has commented, reply with a comment or resolve the issue (if you are sure about your solution).
There was a problem hiding this comment.
I resolved the issue commented as well
The comment is present below
|
Conflicts resolved and google form floated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15
The following changes have been made: