Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DG comments Wk10-Tutorial #75

Open
ryanYtan opened this issue Oct 24, 2019 · 0 comments
Open

DG comments Wk10-Tutorial #75

ryanYtan opened this issue Oct 24, 2019 · 0 comments

Comments

@ryanYtan
Copy link

Sorry not very detailed / specific.

Section 3.2

Sequence Diagram has dangling activation bar
They should talk about why they have the current choice.

3.3

"/ maybe insert screenshot to show expected output"
3.3.2 alternative is trivial (can be improved)

3.4

3.4.1 diagram too excessive
3.4.2 "Excersie we had morphed"
3.4.2 markup for code not enforced in list
3.4.2 markup for code not enforced in paragraph

3.5
no multiplicity for UML
is brackets on "Menstrual Cycle (for Females)" necessary?
really large sequence diagram
got code block in a paragraph in 3.5.2
format is in old frowned upon way
figure 14 DeletePageCommand activation bar dangling
"/ maybe insert a screenshot to show the expected output"
data structures not a good alternative

general comments:
some figures have no figure number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant