Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE-D] User able to input invalid time for facility #198

Closed
nus-pe-script opened this issue Oct 30, 2021 · 0 comments · Fixed by #196
Closed

[PE-D] User able to input invalid time for facility #198

nus-pe-script opened this issue Oct 30, 2021 · 0 comments · Fixed by #196
Assignees
@felix-ong
Labels
bug Something isn't working priority.high Of high importance
Milestone
v1.4

Comments

@nus-pe-script
Copy link

image.png

No checks made to ensure that time is in the correct format HHMM. Providing time as 2700 still allows user to add facility without any problems

Labels: type.FeatureFlaw severity.Low
original: sueann-chua/ped#5
@felix-ong felix-ong self-assigned this Oct 30, 2021
@felix-ong felix-ong added this to the v1.4 milestone Oct 30, 2021
@felix-ong felix-ong mentioned this issue Oct 30, 2021
Merged
@felix-ong felix-ong added priority.high Of high importance bug Something isn't working labels Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felix-ong felix-ong

Labels
bug Something isn't working priority.high Of high importance
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

Fix Facility-related bugs felix-ong/tp
2 participants
@nus-pe-script @felix-ong