Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE-D] Duration is unable to handle large numbers #174

Closed
nus-se-bot opened this issue Oct 29, 2021 · 2 comments · Fixed by #236
Closed

[PE-D] Duration is unable to handle large numbers #174

nus-se-bot opened this issue Oct 29, 2021 · 2 comments · Fixed by #236
Assignees
@wanyu-l
Labels
bug Something isn't working UG

Comments

@nus-se-bot
Copy link

Duration is unable to handle large integers (I assume its because of overflow HAHA).
Would be great to include a disclaimer on the maximum range on duration :)
duration_unable_to_handle_large_numbers.PNG

Labels: severity.Low type.FeatureFlaw
original: yucheng11122017/ped#5
@angnobel angnobel added UG bug Something isn't working labels Oct 31, 2021
@angnobel
Copy link

Change error for overflow

@wanyu-l wanyu-l self-assigned this Oct 31, 2021
@wanyu-l
Copy link

wanyu-l commented Oct 31, 2021

I think I'll cap it at 24Hrs

@wanyu-l wanyu-l linked a pull request Oct 31, 2021 that will close this issue
Update parseDuration #236
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wanyu-l wanyu-l

Labels
bug Something isn't working UG
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update parseDuration wanyu-l/tp
3 participants
@nus-se-bot @angnobel @wanyu-l