Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PE-D][Tester A] Detection of same leaves can be improved #129

Closed
soc-pe-bot opened this issue Nov 3, 2023 · 1 comment
Closed

[PE-D][Tester A] Detection of same leaves can be improved #129

soc-pe-bot opened this issue Nov 3, 2023 · 1 comment
Labels
bug.FeatureFlaw bug.NotAllowedToFix Not within the scope of allowable v1.4 bug fixes severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product.

Comments

@soc-pe-bot
Copy link

Currently, leaves are flagged as being the same if they have the same start and end date for the same employee.

One issue with this is that even after rejecting a leave for the given date range, another pending leave for that date range cannot be added, though it might make sense for an employee to resubmit an application for their desired leave dates after being rejected.

It is also slightly unintuitive that a new leave application can have its duration fall completely within the duration of another approved leave.


Labels: severity.Medium type.FeatureFlaw
original: andytoh1/ped#4

@ryanozx ryanozx added bug.NotFixing Not a bug severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product. bug.FeatureFlaw bug.NotAllowedToFix Not within the scope of allowable v1.4 bug fixes and removed bug.NotFixing Not a bug labels Nov 11, 2023
@ryanozx
Copy link

ryanozx commented Nov 11, 2023

Future planned enhancement: Add checks to allow multiple leave applications with overlapping periods, with additional checks to guarantee that there will be no overlapping approved leaves

@ryanozx ryanozx closed this as completed Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug.FeatureFlaw bug.NotAllowedToFix Not within the scope of allowable v1.4 bug fixes severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product.
Projects
None yet
Development

No branches or pull requests

2 participants