Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Review] jing-xiang #81

Open
wwweert123 opened this issue Mar 31, 2024 · 1 comment
Open

[Code Review] jing-xiang #81

wwweert123 opened this issue Mar 31, 2024 · 1 comment

Comments

@wwweert123
Copy link

image

You can try to employ more slap to make your code cleaner. For example, you can abstract the checking of input to checkValidInput(), and the hashing of the pin to createHash()

image

Nothing much to comment on, except maybe try not to use too much magic literals like "16" and "exit". Very nice code ! 👍 🧠

@jing-xiang
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants