Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Management #88

Closed

Conversation

djleong01
Copy link

Add ability to create different groups and switch between them such that each group maintains their own member and transaction list. Let me know if there is a neater way to implement this outside of LongAh main.

Todo:

  • Renaming and deleting of groups
  • Junit tests
  • Update UG/DG
  • Better UI clarity on which group the user is currently managing?

@djleong01 djleong01 added priority.Medium Nice to have priority.Low Unlikely to do and removed priority.Low Unlikely to do labels Mar 31, 2024
@djleong01 djleong01 added this to the v2.0 milestone Mar 31, 2024
This was linked to issues Mar 31, 2024
Copy link

@jing-xiang jing-xiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's reformat the flow of this increment

@@ -34,6 +34,12 @@ public boolean isExit() {
return false;
}

/**
* Returns whether the current command is a switch command or not.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ayo what

@@ -63,6 +64,8 @@ public static Command parseCommand(String commandString, String taskExpression)
// Fallthrough
case "chart":
throw new LongAhException(ExceptionMessage.COMMAND_NOT_IMPLEMENTED);
case "switchgroup":

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wut

@djleong01 djleong01 closed this Mar 31, 2024
@djleong01 djleong01 deleted the dev/group_management branch April 1, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Medium Nice to have
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Code Review] djleong01 Group Management
2 participants