Implement Blank class to allow for optional Person fields #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 4, 2024
Kitty-001
reviewed
Nov 5, 2024
| } else { | ||
| address = new Address(new Blank()); | ||
| } | ||
|
|
There was a problem hiding this comment.
I feel the modifications to ParserUtil is enough to handle these. Maybe can do something like:
Phone phone = ParserUtil.parsePhone(argumentMultimap.getValue(PREFIX_PHONE).orElse(""));
There was a problem hiding this comment.
Hmm i didnt realise it was an optional
| @@ -10,7 +10,7 @@ public class EmailTest { | |||
|
|
|||
| @Test | |||
| public void constructor_null_throwsNullPointerException() { | |||
| assertThrows(NullPointerException.class, () -> new Email(null)); | |||
| assertThrows(NullPointerException.class, () -> new Email((String) null)); | |||
There was a problem hiding this comment.
to call the correct constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.