Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve use of enum in IncomeComparisonOperator #100

Open
itsme-zeix opened this issue Oct 20, 2024 · 0 comments
Open

Improve use of enum in IncomeComparisonOperator #100

itsme-zeix opened this issue Oct 20, 2024 · 0 comments
Labels
priority.Low Unlikely to do
Milestone

Comments

@itsme-zeix
Copy link

If have time can consider making these greater/equal/less than behavior more type-safe (and more OOP) by implementing enums! Maybe something like this:

public enum IncomeComparisonOperator {
    EQUAL("="),
    GREATER_THAN(">"),
    LESS_THAN("<");
    // some assign symbol logic
}

Originally posted by @iamdiluxedbutcooler in #95 (comment)

@itsme-zeix itsme-zeix added the priority.Low Unlikely to do label Oct 20, 2024
@itsme-zeix itsme-zeix added this to the v1.5 milestone Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Low Unlikely to do
Projects
None yet
Development

No branches or pull requests

1 participant