Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DoobieMultipleResultFunctionWithAggStatus when querying the DB expecting multiple results #219

Open
benedeki opened this issue Jul 3, 2024 · 0 comments
Open

Use DoobieMultipleResultFunctionWithAggStatus when querying the DB expecting multiple results #219

benedeki opened this issue Jul 3, 2024 · 0 comments
Assignees
@TebaleloS
Labels
enhancement New feature or request

Comments

@benedeki
Copy link
Contributor

benedeki commented Jul 3, 2024 •
edited
Loading

Background

At the moment when querying the database expecting multiple results, we don't care about the status returned. That might lead to incorrect behavior.

Feature

Use DoobieMultipleResultFunctionWithAggStatus instead of DoobieMultipleResultFunction to handle the status returned from the database functions.

Proposed Solution

Solution Ideas:

  • upgrade to Fa-DB v0.4.0
  • use the ByFirstErrorStatusAggregator mix-in trait
  • NB! The import path has changed from za.co.absa.fadb to za.co.absa.db.fadb. Similarly the library path has changed from za.co.absa.fa-db to za.co.absa.db.fa-db. (Mass replace could quickly solve it.)
@benedeki benedeki added the enhancement New feature or request label Jul 3, 2024
TebaleloS added a commit that referenced this issue Jul 11, 2024
@TebaleloS
Merge branch 'master' into feature/#219-DoobieMultipleResultFunctionW…
da3f9f6 
…ithAggStatus

# Conflicts:
#	project/Dependencies.scala
#	server/src/test/scala/za/co/absa/atum/server/api/controller/CheckpointControllerUnitTests.scala
@lsulak lsulak mentioned this issue Jul 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TebaleloS TebaleloS

Labels
enhancement New feature or request
Projects
CPS small repos project
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benedeki @TebaleloS