From 5b3576b57629c5a0072f1a697197c5d1295da88b Mon Sep 17 00:00:00 2001 From: Buckram Date: Tue, 13 Aug 2024 14:56:31 +0300 Subject: [PATCH] TODOs cleanup --- framework/packages/abstract-std/src/adapter.rs | 2 +- framework/packages/abstract-std/src/app.rs | 3 --- modules/contracts/apps/etf/src/handlers/receive.rs | 1 - modules/contracts/apps/payment/src/handlers/receive.rs | 1 - modules/contracts/apps/subscription/src/handlers/receive.rs | 1 - 5 files changed, 1 insertion(+), 7 deletions(-) diff --git a/framework/packages/abstract-std/src/adapter.rs b/framework/packages/abstract-std/src/adapter.rs index 63cfbf0c54..9ed9805b97 100644 --- a/framework/packages/abstract-std/src/adapter.rs +++ b/framework/packages/abstract-std/src/adapter.rs @@ -30,7 +30,7 @@ pub type InstantiateMsg = /// Trait indicates that the type is used as an app message /// in the [`ExecuteMsg`] enum. -/// It's just a marker trait +/// Enables [`Into`] for BOOT fn-generation support. pub trait AdapterExecuteMsg: Serialize {} impl From for ExecuteMsg { fn from(request: T) -> Self { diff --git a/framework/packages/abstract-std/src/app.rs b/framework/packages/abstract-std/src/app.rs index b0b6d64e7c..783482c5c9 100644 --- a/framework/packages/abstract-std/src/app.rs +++ b/framework/packages/abstract-std/src/app.rs @@ -27,9 +27,6 @@ use cosmwasm_std::{Addr, Empty}; use cw_controllers::AdminResponse; use serde::Serialize; -// TODO: Current implementation don't work with CustomMessages -// Because if we do some `impl From for X where T: SomeTrait`, we don't allow to implement ANY `From for Y` outside of this crate - /// Trait indicates that the type is used as an app message /// in the [`ExecuteMsg`] enum. /// Enables [`Into`] for BOOT fn-generation support. diff --git a/modules/contracts/apps/etf/src/handlers/receive.rs b/modules/contracts/apps/etf/src/handlers/receive.rs index f9bfe1acc6..b44fdcc887 100644 --- a/modules/contracts/apps/etf/src/handlers/receive.rs +++ b/modules/contracts/apps/etf/src/handlers/receive.rs @@ -10,7 +10,6 @@ use crate::{ state::{State, STATE}, }; -// TODO: Custom handler /// handler function invoked when the vault dapp contract receives /// a transaction. In this case it is triggered when either a LP tokens received /// by the contract or when the deposit asset is a cw20 asset. diff --git a/modules/contracts/apps/payment/src/handlers/receive.rs b/modules/contracts/apps/payment/src/handlers/receive.rs index 92cdd05d50..49c75e3fef 100644 --- a/modules/contracts/apps/payment/src/handlers/receive.rs +++ b/modules/contracts/apps/payment/src/handlers/receive.rs @@ -4,7 +4,6 @@ use cw_asset::Asset; use crate::contract::{AppResult, PaymentApp}; -// TODO: custom execute msg pub fn receive_handler( deps: DepsMut, env: Env, diff --git a/modules/contracts/apps/subscription/src/handlers/receive.rs b/modules/contracts/apps/subscription/src/handlers/receive.rs index e441d98542..ffc7e0aba6 100644 --- a/modules/contracts/apps/subscription/src/handlers/receive.rs +++ b/modules/contracts/apps/subscription/src/handlers/receive.rs @@ -8,7 +8,6 @@ use crate::{ msg::DepositHookMsg, }; -// TODO: custom execute msg pub fn receive_cw20( deps: DepsMut, env: Env,