Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLSL ShaderGen: time_float and frame_float do not have any effect #1952

Open
hybridherbst opened this issue Jul 26, 2024 · 6 comments
Open

Comments

@hybridherbst
Copy link
Contributor

Related to #1951

I believe the attached file should have some animation based on application time, however it just stays still in MaterialXWebViewer.
marbleTime.mtlx.zip

image
@hybridherbst
Copy link
Contributor Author

Edit: in some applications the time nodes show up as not connected, this one here should work:
myFile2.mtlx.zip

@kwokcb
Copy link
Contributor

kwokcb commented Jul 27, 2024

There is no "play" functionality here nor in the desktop viewer. For the hardware case the u_frame shader uniform needs to be updated and bound as mentioned here

@hybridherbst
Copy link
Contributor Author

Please consider it a feature request :)

@jstone-lucasfilm jstone-lucasfilm changed the title MaterialXWebViewer: time_float and frame_float do not have any effect GLSL ShaderGen: time_float and frame_float do not have any effect Aug 3, 2024
@jstone-lucasfilm
Copy link
Member

Thanks for this feature request, @hybridherbst, and I've just updated the title to clarify that this feature is missing in our GLSL shader generation, which both the Viewer and Graph Editor leverage for rendering

@hybridherbst
Copy link
Contributor Author

Thanks @jstone-lucasfilm! I think in addition to the shader generation, the host application also needs to updates the uniforms, right?

@jstone-lucasfilm
Copy link
Member

Good point, @hybridherbst, and indeed those updates should be made to the Viewer and Graph Editor when this feature is added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants