Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/1881 handle bad journey retrieve-by-key responses gracefully #1887

Merged

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Nov 21, 2024

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added the c/journey COMPONENT label Nov 21, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.5.1 milestone Nov 21, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Nov 21, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 21, 2024
Copy link

Coverage Report

Commit:768de08
Base: develop@15293dc

Type Base This PR
Total Statements Coverage  69.72%  69.72%  (+0%)
Total Branches Coverage  69.01%  69.01%  (+0%)
Total Functions Coverage  81.87%  81.87%  (+0%)
Total Lines Coverage  69.72%  69.72%  (+0%)
Details (changed files):
File Statements Branches Functions Lines
lib/metadataTypes/Journey.js  59.01%  59.44%  76.19%  59.01%

@JoernBerkefeld JoernBerkefeld linked an issue Nov 21, 2024 that may be closed by this pull request
2 tasks
@JoernBerkefeld JoernBerkefeld merged commit 9542722 into develop Nov 21, 2024
11 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bug/1881-gracefully-handle-journey-key-not-found branch November 21, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/journey COMPONENT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] gracefully handle journey-key-not-found
1 participant