Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portals are buggy #91

Open
JHarris12345 opened this issue Dec 23, 2020 · 28 comments
Open

Portals are buggy #91

JHarris12345 opened this issue Dec 23, 2020 · 28 comments

Comments

@JHarris12345
Copy link

JHarris12345 commented Dec 23, 2020

Portals are slightly bugged. If you jump into one (for ones that are flat on the ground) and you instantly run as you land in it.. If it has to search through a couple of locations, it will cancel the TP and you will be in the portal having to wait for your cooldown.

(yes cancel rtp on move is disabled)

GIF for reference https://gyazo.com/f3b1c154cbdca27d2bf450d1b0e23775

@RoboMWM
Copy link
Collaborator

RoboMWM commented Dec 23, 2020

hmm, are the post commands being called still even if the teleport failed to occur? Seems like something else is going on. Enable debug and send logs and config.

@JHarris12345
Copy link
Author

So here is the debug from when Lyds enters to portal (but also continues running as its retrying different locations)

https://pastebin.com/ebXSiYw6

Config is here: https://pastebin.com/mcz4zm9c

@RoboMWM
Copy link
Collaborator

RoboMWM commented Dec 23, 2020

please include all of it then

@JHarris12345
Copy link
Author

That was all of it

@JHarris12345
Copy link
Author

Look, it never went further, the tp got cancelled because I was running as I entered the portal (like the gif) https://pastebin.com/Fv9DYbsv

@RoboMWM
Copy link
Collaborator

RoboMWM commented Dec 23, 2020

(but also continues running as its retrying different locations)

what do you mean by this then.

@JHarris12345
Copy link
Author

If you see the gif in the 1st message, you'll kinda see that as I jump into the portal I continue pressing the w key as I land (so as I land, im instantly moving)

@RoboMWM
Copy link
Collaborator

RoboMWM commented Dec 23, 2020

and /version wild and /version

@RoboMWM
Copy link
Collaborator

RoboMWM commented Dec 23, 2020

I don't get how that's retrying different locations.....????? retrying what?

@JHarris12345
Copy link
Author

Wild version 2.27-e5669bb

Server version paper 1.16.4 build 342

@RoboMWM
Copy link
Collaborator

RoboMWM commented Dec 23, 2020

anyways I'm guessing something else is blocking the teleport, because those logs indicate the player is being teleported. Try without other plugins

@JHarris12345
Copy link
Author

Not retying maybe, when it comes up at the top of the screen saying "searching locations 1/X" for example. If I move during that it just doesnt TP as shown in the gif

@RoboMWM
Copy link
Collaborator

RoboMWM commented Dec 23, 2020

wait so it does work if you "don't move"?

@JHarris12345
Copy link
Author

If I just jump in and dont move at all, it will work

@RoboMWM
Copy link
Collaborator

RoboMWM commented Dec 23, 2020

do the logs look any different between the two scenarios? Can you paste one without moving and one with moving?

@RoboMWM
Copy link
Collaborator

RoboMWM commented Dec 23, 2020

ya, something else is interfering.

[17:41:03] [Server thread/INFO]: [WildTP] preping 2 port 2 Location{world=CraftWorld{name=world},x=-18776.0,y=68.0,z=-29016.0,pitch=0.0,yaw=0.0}
[17:41:03] [Server thread/INFO]: [WildTP] Teleporting princess_lydsLocation{world=CraftWorld{name=world},x=-18776.0,y=68.0,z=-29016.0,pitch=0.0,yaw=0.0}
[17:41:03] [Server thread/INFO]: [WildTP] princess_lyds Teleported to Location{world=CraftWorld{name=world},x=-535.7494030275614,y=185.0,z=-817.3875791692711,pitch=16.350042,yaw=89.82024}

@RoboMWM
Copy link
Collaborator

RoboMWM commented Dec 23, 2020

I'm gonna guess a bad anticheat or something? Idk. I'm looking at the code tho and it waits until the teleport method has finished before printing out that last debug line there I pasted.

@RoboMWM
Copy link
Collaborator

RoboMWM commented Dec 23, 2020

and it's calling Bukkit's teleport method Player#teleport, so definitely something else is getting in the way.

@JHarris12345
Copy link
Author

Ok Ill check it out

@JHarris12345
Copy link
Author

Weird I cant replicate it even with the same plugins

@JHarris12345
Copy link
Author

And it works fine for OPs, just cancels for players, any ideas?

@JHarris12345
Copy link
Author

OHH its when people are in survival mode it bugs out

@JHarris12345
Copy link
Author

So if they are in creative, works fine

@JHarris12345
Copy link
Author

It's NoCheatPlus, got it :D

@JHarris12345
Copy link
Author

It's the survivalfly check so I cant really disable it, anything that can be done inside wildtp as to it triggering survival fly?

@RoboMWM
Copy link
Collaborator

RoboMWM commented Dec 24, 2020

Hmm, whoever's running the fork needs to listen for plugin teleports.

I know there were issues with players going into End Portals before, but that was because Bukkit never properly notified plugins about the teleport. But... this should be doable to detect because it's a plugin triggering the teleport.

Take it up with NCP basically.

@JHarris12345
Copy link
Author

Alright perfect thanks, will let them know. We can close this off

@RoboMWM
Copy link
Collaborator

RoboMWM commented Dec 24, 2020

ya, there should be a debug toggle in NCP too that may help them out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants