Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLALCHEMY_TEST_DATABASE_URI is fine for a name, but personally, I would go with SQLALCHEMY_DATABASE_URI_TEST whenever I have a variable that has an environment as part of the name. If this is done consistently, this allows for a configuration pattern where can set un-versioned defaults, but then provide per-environment values by trying to find an equivalent var with the environment appended. #38

Open
tildeee opened this issue Apr 27, 2021 · 0 comments

Comments

@tildeee
Copy link
Collaborator

tildeee commented Apr 27, 2021

SQLALCHEMY_TEST_DATABASE_URI is fine for a name, but personally, I would go with SQLALCHEMY_DATABASE_URI_TEST whenever I have a variable that has an environment as part of the name. If this is done consistently, this allows for a configuration pattern where can set un-versioned defaults, but then provide per-environment values by trying to find an equivalent var with the environment appended.

We don't really need this here (the test db is largely a one off, and if we had staging/production, we would be supplying an entirely separate environment configuration (probably through a dashboard), so we definitely do NOT need to change this, but I wanted to mention it.

Originally posted by @anselrognlie in #11 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant