Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review current generated code #3

Open
odeheurles opened this issue Dec 4, 2013 · 1 comment
Open

Review current generated code #3

odeheurles opened this issue Dec 4, 2013 · 1 comment

Comments

@odeheurles
Copy link

Current generated code is very close to Java API, which is not very idiomatic for a C# developer. We need to go through the generated code and decide how the different SBE constructs (fields, composites, bitsets, etc..) should be implemented and exposed in .NET.

Output of this task should be a list of the changes to apply in the code generation.

Some initial ideas:

  • optional fields as Nullable<>
  • set to be implemented a C# enum with [Flag]
  • groups API is horrible, need to be looked at
@mattbarrett
Copy link

WrapForEncode and WrapForDecode can be improved. Doesn't read very well.

I think we can remove the non-idiomatic iteration completely, and just have a .net version that throws when its misused (different threads, same thread iterating more than once) for no allocation. If allocation is allowed, then perhaps a different implementation that is less constrained?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants