Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0 RFC/epic: Drop support for IE11, Ember <2.4, and more #819

Open
8 of 11 tasks
mixonic opened this issue Apr 13, 2020 · 5 comments
Open
8 of 11 tasks

3.0 RFC/epic: Drop support for IE11, Ember <2.4, and more #819

mixonic opened this issue Apr 13, 2020 · 5 comments
Labels

Comments

@mixonic
Copy link
Member

mixonic commented Apr 13, 2020

Motivation

There are several costs to ember-table supporting legacy platforms, and we're ready for a major release.

  • Contributors keep stumbling on the legacy use of sendAction in this codebase (most recently at add columns array to onReorder() and onResize() #818). Today we cannot remove sendAction since it is required for Ember 1.12 and this library supports Ember 1.12.
  • Additionally this library supports IE11 despite that browser being extremely uncommon in modern usage. Indeed at Addepar we no longer have a need to support IE11, and I think we're one of the last.
  • We want to land Add horizontal scroll indicator feature #814, but may require a breaking change to the DOM (a new <div>)
  • We want to drop support for legacy Node, < v10
  • As part of an effort to update the ember-cli-sass version used here and elsewhere we make changes in Drop the legacy style build steps addepar-style-toolbox#38 which may alter how the SASS of an application works (no longer would an example app have a patched @import to import only once, instead an application should provide that functionality itself if desired).

The plan & progress

The repo now has a branch 3.0-beta, in draft state at #831. We will land patches for an eventual 3.0 release into that branch, and will make incremental beta releases along the way. Already you can find v3.0.0-4 released via NPM.

I propose a list of changes before a 3.0 final is declared. The task list is:

@mixonic
Copy link
Member Author

mixonic commented Apr 21, 2020

We've been discussing this with maintainers, and we intend to move forward on dropping IE11

@ghost
Copy link

ghost commented Jun 1, 2020

see #800 for one conversation.

@mixonic
Copy link
Member Author

mixonic commented Aug 7, 2020

We're moving forward with this! I'm updating the issue description with more details on the execution and plan.

@mixonic mixonic changed the title Drop support for IE11, Ember 1.12 (Major ver. RFC?) 3.0 RFC/epic: Drop support for IE11, Ember <2.4, and more Aug 7, 2020
@twokul twokul mentioned this issue Aug 13, 2020
@mixonic mixonic added the 3.0 label Jan 11, 2021
@mixonic mixonic mentioned this issue Jan 21, 2021
@twokul twokul mentioned this issue Feb 2, 2021
12 tasks
@mixonic
Copy link
Member Author

mixonic commented Feb 3, 2021

Ok! So we kicked off this goal in April 2020, and after a very long year we're nearly ready to pull the trigger on a stable 3.0 release. @twokul @kpfefferle and @ahmacleod have been landing some excellent work into the beta releases.

Additionally in that time Addepar has removed our own requirement that ember-table continue to support Ember 2.4. We're interested in upping the minimum supported version of Ember to 2.8.3.

Is there feedback from repo watchers on this step? If there is little in the way of feedback, we're inclined to bump the baseline and hope that helps our 3.x release cycle last a little bit longer.

@twokul
Copy link
Contributor

twokul commented Feb 3, 2021

I would strongly support 2.8 😄

twokul added a commit that referenced this issue Feb 5, 2021
Based on the feedback on
#819 (comment),
we are dropping Ember 2.4 testing matrix.
twokul added a commit that referenced this issue Feb 5, 2021
Based on the feedback on
#819 (comment),
we are dropping Ember 2.4 testing matrix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants