Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commas for numbers over 1,000 for the “Average upstream response time” table #7590

Open
3 tasks done
handcoding opened this issue Jan 23, 2025 · 1 comment
Open
3 tasks done

Comments

@handcoding
Copy link

handcoding commented Jan 23, 2025

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to request a feature or enhancement and not ask a question

The problem

As a follow-up to issue #7329 (General Statistic comma format the numbers), for which there was a recent commit, I had also wanted to ask whether it might be possible to implement this same fix for thousands separators for the dashboard’s Average upstream response time table, such as shown below?

Image

Proposed solution

Format the numbers using the same formatting as the Top Clients and Top Domains counts..

Alternatives considered and additional information

(Filed this as a separate issue as requested by @ainar-g.)

@ainar-g
Copy link
Contributor

ainar-g commented Jan 23, 2025

The duration values in the query log should probably also be formatted, while we're at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants