Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a command-line switch to enable DoH without HTTPS #146

Open
hukaixuan opened this issue May 28, 2021 · 3 comments · May be fixed by #302
Open

Add a command-line switch to enable DoH without HTTPS #146

hukaixuan opened this issue May 28, 2021 · 3 comments · May be fixed by #302
Labels
enhancement New feature or request

Comments

@hukaixuan
Copy link

We want to set a load balance and put the dnsproxy behead it, only put the HTTPS certificate on load balance.
Found that we can't start dnsproxy with no TLS config:
image
any plan to support this scenario?
@ameshkov
Copy link
Member

Internally, it is supported. We probably should add a command-line switch to allow it.

@ameshkov ameshkov changed the title Any plan to support start doh listen port without TLS config? Add a command-line switch to enable DoH without HTTPS May 29, 2021
@ameshkov ameshkov added the enhancement New feature or request label May 29, 2021
@ameshkov
Copy link
Member

Ah, I was too fast with the response. It's supported in AGH since it implements an HTTP layer by itself. Not in dnsproxy. We'll keep this usecase in mind when we'll be refactoring the "server" part of dnsproxy.

coolquasar pushed a commit to coolquasar/dnsproxy that referenced this issue Aug 14, 2021
Pull request AdguardTeam#146: ADG-3944 add specs
fa7c8ce 
Merge in DNS/dnsproxy from add-specs to master

* commit 'b4adffa743737a2d3288dd3bd7c3e689adedcd70':
  remove redundant go param
  Revert "remove makefile, remove redundant go param"
  Revert "change docker image"
  change docker image
  remove makefile, remove redundant go param
  some fixes
  ADG-3944 add specs
@gdm85 gdm85 linked a pull request Dec 22, 2022 that will close this issue
Open
@gdm85
Copy link

gdm85 commented Dec 22, 2022

I opened #302 to address this, please review and suggest improvements. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

proxy: add support for HTTP-only listeners for DoH gdm85/dnsproxy
3 participants
@ameshkov @gdm85 @hukaixuan