Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggestion: ilevel module - show numbers at bottom of the item #303

Closed
mitterman2 opened this issue Sep 3, 2018 · 4 comments · May be fixed by #496
Closed

suggestion: ilevel module - show numbers at bottom of the item #303

mitterman2 opened this issue Sep 3, 2018 · 4 comments · May be fixed by #496
Labels
Enhancement Pending

Comments

@mitterman2
Copy link

i couldnt see an option to display the ilevel on gear in bags at the bottom of the icon instead of the top.
this was interfering with the pawn upgrade arrow which is also not moveable.
changing line 104 in itemlevel.lua to: text:SetPoint("BOTTOMLEFT", button, 3, 1)
this changed it to display at bottom.
perhaps this could be an option in the config?

great addon btw and thanks for all the hard work!
@Beet4
Copy link

Beet4 commented Sep 4, 2018

You got my vote on this, it's has been bugging me for quite some time that the upgrade icon is covered by the ilvl.

@ZehelFenris
Copy link

i had the problem that both my pawn upgrade arrow and my addon that shows if i got the transmog or not is both on the top of the item which makes the top quite cluttered if i have a BoE item i havent learned look from thats an upgrade in my inventory

@Alyred
Copy link

Alyred commented Oct 8, 2018

This has actually been fixed in Pull #206 and has been working well since (though the menu layout could use some alignment). I'm not sure why this hasn't been merged, honestly.
Check the code there, but it will take some manual editing since some of the files have had some updates to the numbers to adjust for the iLevel squish.

@legowxelab2z8 legowxelab2z8 mentioned this issue Oct 18, 2020
Open
This was referenced Oct 18, 2020
Closed
Closed
Closed
Closed
Closed
@Alyred
Copy link

Alyred commented Dec 7, 2020

Any idea when we can get this merged? Testing has gone well, but we're starting to see other pulls that might conflict.
#499 should be merged in too, I'll post a reminder there.

@Cidan Cidan closed this as completed Aug 21, 2022
@Talyrius Talyrius reopened this Sep 8, 2023
@Talyrius Talyrius mentioned this issue Sep 8, 2023
Closed
@Cidan Cidan closed this as completed Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Options to Move ItemLevel text legowxelab2z8/AdiBags
6 participants
@Talyrius @Cidan @Alyred @Beet4 @mitterman2 @ZehelFenris