Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No keyring after pre-patch WoTLK #691

Closed
Iowerth opened this issue Sep 3, 2022 · 10 comments
Closed

No keyring after pre-patch WoTLK #691

Iowerth opened this issue Sep 3, 2022 · 10 comments

Comments

@Iowerth
Copy link

Iowerth commented Sep 3, 2022

Describe the bug

  • There is no keyring after pre-patch WoTLK.

World of Warcraft Release and Version (Retail 9.2.7, etc)

  • WoTLK 3.4.0

AdiBags Version

  • v1.9.37

Have you tried disabling all your other addons to ensure only this addon causes the issue?

  • No

Additional context
There was a keyring before WoTLK.

@Cidan
Copy link
Contributor

Cidan commented Sep 3, 2022

I think the keyring code was taken out quite some time ago, and was proposed to be readded in #590. We'll take a look at this at some point in the near future.

@navara
Copy link

navara commented Sep 10, 2022

It was never there in TBC.

See 2020 report #469

@Iowerth
Copy link
Author

Iowerth commented Sep 10, 2022

It was never there in TBC.

See 2020 report #469

It was in AdiBags and I used it.

@david-driscoll
Copy link

It was there, I had categories to show hide/key rings. Looking at the history though I don't know how or when it got changed which is really strange, lol.

@Talyrius
Copy link
Contributor

Talyrius commented Sep 11, 2022

Looking at the history though I don't know how or when it got changed which is really strange, lol.

It (adb91fe) didn't survive the unification of the codebase (#648).

@EvelynSays
Copy link

Any word on this? It's pretty frustrating given the number of keys in the game now!

@navara
Copy link

navara commented Sep 16, 2022

Any word on this? It's pretty frustrating given the number of keys in the game now!

This macro still works - as a workaround
/script ToggleBag(KEYRING_CONTAINER)

@Cidan
Copy link
Contributor

Cidan commented Sep 16, 2022

It's on the list to get to -- sorry folks. We have actual jobs and families, we'll get to it as soon as we can, promise!

@Iowerth
Copy link
Author

Iowerth commented Jan 6, 2023

Watching that new updates are releasing, but still no fix for this :(

@xinomahc
Copy link

any plan(s) of "fixing" this soonish?

@Cidan Cidan closed this as completed Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants