Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category Report including "past" event members #1492

Open
Rvice opened this issue Oct 4, 2023 · 4 comments
Open

Category Report including "past" event members #1492

Rvice opened this issue Oct 4, 2023 · 4 comments

Comments

@Rvice
Copy link
Contributor

Rvice commented Oct 4, 2023

#1459 (4.2.12) and 4.3.0 Beta 1

See the category report https://www.admidio.org/playground/adm_program/modules/category-report/category_report.php for Testy O'Testerson

Should not be in this list and the user still has no active roles.

@Fasse
Copy link
Member

Fasse commented Oct 5, 2023

@rmbinder Is it helpful to show the event roles within the category report? Or should the category report better only show real roles?

The event roles have a special logic when assigning members.

@Rvice
Copy link
Contributor Author

Rvice commented Oct 5, 2023

In how I use the Category Report, I'm looking specifically for "membership" statuses and not "former" statuses.

In this Example: Testy O'Testerson is a FORMER member AND attended an event in the past. If, Testy was just a FORMER member, he would not show up in the Category Report (today).

This is where things go sideways. If a person attended an event in the past (i.e. the event is not NOW) and the category report is run, I expect not to see them.

The argument for Testy being a FORMER member AND attending an event that is still Active at the time of the category report, I would understand.

Adding the user to the event is correct, in that a former member where a membership is required to participate, is blocked. I had to finagle the event and the "member" in the playground to get this scenario to match my setup where the member actually attended an event in 2021, their membership discontinued in 2022 and they are still showing on the category report (with no Role memberships) today.

We have some old-time members that like Excel/Print copies of the roster when requested. To do this, I have some Google Sheet magic off the Category Report and using the Role/Group "former members" to show those we lost.

@rmbinder
Copy link
Member

rmbinder commented Oct 5, 2023

As far as I can remember, there was once a request in the forum that the category report should be able to display events. In all role selections it is possible to select events. I can't yet say why "past" event members are displayed here, I have to analyze it in more detail. But I wouldn't delete the event roles completely.

@Rvice
Copy link
Contributor Author

Rvice commented Oct 5, 2023

Might be better to have a different property for event attendance, outside of a role. Then add a config param to the category report to "include events"

That way, the forum request is still satisfied, while this scenario is as well.

@Fasse Fasse added bug and removed discussion labels Oct 9, 2023
@Fasse Fasse added this to the v4.2.13 milestone Oct 9, 2023
@Fasse Fasse changed the title Regression: Category Report still including "past" event members Category Report including "past" event members Oct 9, 2023
@Fasse Fasse modified the milestones: v4.2.13, v4.2.14 Nov 1, 2023
@Fasse Fasse modified the milestones: v4.2.14, v4.2.15 Nov 25, 2023
@Fasse Fasse removed this from the v4.2.15 milestone Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants