Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClassCastException seen in the field for jcifs.smb.SmbTransportImpl.setupResponses #326

Open
courville opened this issue Dec 21, 2022 · 1 comment
Open

ClassCastException seen in the field for jcifs.smb.SmbTransportImpl.setupResponses #326

courville opened this issue Dec 21, 2022 · 1 comment

Comments

@courville
Copy link

Seen in the field with nova my android video player app reported on my sentry crashnalytics backend (no clue what triggers it). Here is the stacktrace collected:

java.lang.ClassCastException: jcifs.internal.smb1.com.SmbComBlankResponse cannot be cast to jcifs.internal.smb1.AndXServerMessageBlock
    at jcifs.smb.SmbTransportImpl.setupResponses(SmbTransportImpl.java:1087)
    at jcifs.smb.SmbTransportImpl.sendrecv(SmbTransportImpl.java:927)
    at jcifs.smb.SmbTransportImpl.send(SmbTransportImpl.java:1578)
    at jcifs.smb.SmbTransportImpl.send(SmbTransportImpl.java:1542)
    at jcifs.smb.SmbSessionImpl.logoff(SmbSessionImpl.java:1195)
    at jcifs.smb.SmbTransportImpl.getSmbSession(SmbTransportImpl.java:392)
    at jcifs.smb.SmbTransportImpl.getSmbSession(SmbTransportImpl.java:106)
    at jcifs.smb.SmbTreeConnection.connectHost(SmbTreeConnection.java:566)
    at jcifs.smb.SmbTreeConnection.connectHost(SmbTreeConnection.java:489)
    at jcifs.smb.SmbTreeConnection.connect(SmbTreeConnection.java:465)
    at jcifs.smb.SmbTreeConnection.connectWrapException(SmbTreeConnection.java:426)
    at jcifs.smb.SmbFile.ensureTreeConnected(SmbFile.java:559)
    at jcifs.smb.SmbEnumerationUtil.doEnum(SmbEnumerationUtil.java:221)
    at jcifs.smb.SmbEnumerationUtil.listFiles(SmbEnumerationUtil.java:279)
    at jcifs.smb.SmbFile.listFiles(SmbFile.java:1287)
    at com.archos.filecorelibrary.jcifs.JcifListingEngine$JcifListingThread.run(JcifListingEngine.java:113)

jcifs-ng master is used (2684489).
mbechler added a commit that referenced this issue Jan 5, 2023
@mbechler
Add type check for blank responses (logoff), disable SMB1 batching by…
2bbc749 
… default (#326)

SMB1 batching had been (accidentially) disabled previously anyways,
has little benefit and may trigger additional bugs.
@courville
Copy link
Author

courville commented Feb 9, 2023 •
edited
Loading

Thank you! Connecting the dots with nova-video-player/aos-AVP#819
FYI it fixed a regression on Apple time capsule SMB1 server for some of my users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@courville