watch() filter inconsistent behaviour

[ccudmore]

With the following code:

      SmbWatchHandle watcher = root.watch(FileNotifyInformation.FILE_ACTION_ADDED, true);
      for (;;) {
        List<FileNotifyInformation> changes = watcher.watch();
        for (FileNotifyInformation i : changes) {
          System.out.println(i.getAction() + ":"+i.getFileName());
        }
      }

File add and delete actions are both returned by the filter. Adding a file and deleting it results in:
1:Test.txt
2:Test.txt

[mbechler]

The filter should be directly passed to the SMB server. I don't see how that would fail in the library, but you could easily verify this by checking the CHANGE_NOTIFY request with e.g. Wireshark. Everything else is reponsibility of the server, unless something goes wrong with decoding the response, this looks like a server bug to me. You certainly could add filtering on your side, but I'm not sure I want to add that to the library.