Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift generated code has some redundant lines #122

Open
fadi-botros opened this issue Sep 21, 2018 · 0 comments
Open

Swift generated code has some redundant lines #122

fadi-botros opened this issue Sep 21, 2018 · 0 comments

Comments

@fadi-botros
Copy link

When you generate files using Swift generator, you find both NSCoding and toDictionary/fromDictionary

I think it could be more readable and small if the NSCoding comformance was just delegating to toDictionary and fromDictionary

Also this approach is more Objective-C than Swift, in Swift we just have Encodable/Decodable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fadi-botros