Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old Firefox v52 target in preset-env breaking build #18

Open
kriscarle opened this issue Nov 11, 2021 · 0 comments
Open

Old Firefox v52 target in preset-env breaking build #18

kriscarle opened this issue Nov 11, 2021 · 0 comments

Comments

@kriscarle
Copy link

kriscarle commented Nov 11, 2021

Please consider upgrading the minimum browser targets or maybe using browserslist at https://github.com/Airtable/blocks/blob/master/packages/webpack-bundler/src/javascript_config.ts#L5

In my case the latest version of Mapbox GL (v2.6) now includes an object spread operator in the build. Object spread needs Firefox 55, but the CLI is targeting >52 https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax#browser_compatibility Firefox v52 is from 2017?

Alternatively, an option to skip transpilation of specific modules would also work. I tried the Webpack '!' exclude before the module name but that isn't working in this setup.

Alternatively an option to include specific modules for transpilation would work (had that backwards) I think the issue is that babel-loader expects the imports to either be compatible with the target or included for transpilation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant