Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Undo image transformations #278

Closed
cd-FileX opened this issue Aug 9, 2024 · 10 comments
Closed

[FEATURE REQUEST] Undo image transformations #278

cd-FileX opened this issue Aug 9, 2024 · 10 comments
Labels
enhancement New feature or request

Comments

@cd-FileX
Copy link

cd-FileX commented Aug 9, 2024

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Image transformations are not undoable at once, but only for single pages.

Describe the solution you'd like
A marker in the transform images dialog for the throughout selected option.

Describe alternatives you've considered
An undo button.

Additional context
Add any other context or screenshots about the feature request here.
Related to #279

@cd-FileX cd-FileX added the enhancement New feature or request label Aug 9, 2024
@farfromrefug
Copy link
Collaborator

@cd-FileX nnot sure why this would be needed. You can already "unselect" transformations.
Maybe i am not understanding which transformations you are talking about

@cd-FileX
Copy link
Author

About batch editing/transformation, so editing multiple images at once

@farfromrefug
Copy link
Collaborator

@cd-FileX ok i see now. Not sure how an undo would work. Not easy to implement

@cd-FileX
Copy link
Author

I guess you would have to track which images were changed and what changes were made.
Also, if there is not already one, you should save a config file or data of every image.
Then you can take this data and mark the option in the multiple transformation dialogue.
Else you could also just do it with a switch, so images which have the transformation but the switch is toggled off, get the transformation removed. The other way around if it is turned on the transformation in being added.

@farfromrefug
Copy link
Collaborator

I guess you would have to track which images were changed and what changes were made. Also, if there is not already one, you should save a config file or data of every image. Then you can take this data and mark the option in the multiple transformation dialogue. Else you could also just do it with a switch, so images which have the transformation but the switch is toggled off, get the transformation removed. The other way around if it is turned on the transformation in being added.

Yes i would have to track more history for image because of consecutive changes. I dont think it is worth it. Hope you understand

@cd-FileX
Copy link
Author

I understand it too well that it's a lot of work.
But if you could implement that switch thing I mentioned before, that would also solve this problem.

@farfromrefug
Copy link
Collaborator

@cd-FileX i dont sée what it would solve. There is never a case where an image is marked as transformed while not being transfromed, or the contrary. Even when it crashes!
I am.sorry i dont sée what the issue really is except from the crash.
You can always untransform images by selecting transform images and do it with all unselected

@cd-FileX
Copy link
Author

Ah, just didn't know that... '^^
Maybe in this case a switch would make this just more obvious, though there is no problem anymore. Thanks for your help

@farfromrefug
Copy link
Collaborator

@cd-FileX you are right I could make it easier to understand

@farfromrefug
Copy link
Collaborator

@cd-FileX there is now a reset button so you know what you are doing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants