Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove memmap dependency #417

Open
Tracked by #442
ibaryshnikov opened this issue Sep 30, 2021 · 0 comments
Open
Tracked by #442

Remove memmap dependency #417

ibaryshnikov opened this issue Sep 30, 2021 · 0 comments
Assignees
Labels
1 high priority enhancement New feature or request

Comments

@ibaryshnikov
Copy link

We had a memory leak related to working with too many open files simultaneously, because phase1-coordinator and phase1-cli rely on memmap. Also, verifier and contributor require to write the challenge on disk before running the computation. And file system calls often return errors. Having the ability to do the computations in memory rather than on open files will reduce the possibility of runtime errors, as well as the possibility of memory leaks related to holding the files open for too long. We can safely replace the memory map with fs read/write operations.

@ibaryshnikov ibaryshnikov added enhancement New feature or request 1 high priority labels Sep 30, 2021
@ibaryshnikov ibaryshnikov added this to the Phase II Setup milestone Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 high priority enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant