Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an "Unknown" event type for sections when discharge history is unclear #19

Open
AlexLipp opened this issue May 20, 2024 · 0 comments

Comments

@AlexLipp
Copy link
Owner

Currently, if a sequence of Alerts is reached which "makes no sense" (e.g., a "Stop" followed by another "Stop"), we simply ignore the alerts. However, this by default, then means it is displayed or described as "not discharging" which is erroneous. Instead, it would be preferable to display it as a new type of "Unknown" event type starting from when the discrepancy first appears and ending when it has finished. Inspecting the logs, these events are rare and do not make up a significant period of time. Nonetheless, it would be beneficial to better reflect this edge case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant