Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better check for data internal consistency than via unit-testing #38

Open
AlexLipp opened this issue Nov 28, 2024 · 0 comments
Open

Better check for data internal consistency than via unit-testing #38

AlexLipp opened this issue Nov 28, 2024 · 0 comments

Comments

@AlexLipp
Copy link
Owner

Some WaterCompanies use the StatusStart field on the API instead of the LatestEventEnd field. However, sometimes these don't always accord, and so they fail the unit-tests. This seems slightly harsh on the software given bad input datasets. However, we would like to be able to test this sensibly. So, perhaps a warning during object initiation rather than failing the unit-test?

Similarly, unit-tests are being failed by false time-stamps and incorrect coordinates. Should these be unit-tests or errors with the data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant