Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace writer.Flush() with stream.Flush() #12398

Open
cholmcc opened this issue Dec 5, 2023 · 1 comment
Open

Replace writer.Flush() with stream.Flush() #12398

cholmcc opened this issue Dec 5, 2023 · 1 comment

Comments

@cholmcc
Copy link
Contributor

cholmcc commented Dec 5, 2023

rapidjson::Writer::Flush was introduced 15th of March, 2017,
without updating the version number (last version update is
from 25th of August, 2016 from 1.0.2 to 1.1.0). It is therefore not possible to detect at build time if Writer::Flush is available.

Note that rapidjson::Writer::Flush simply calls rapidjson::OStreamWrapper::Flush.

The authors of rapidjson should really get their act together and bump the version when they change the API.

@Yuvrajsinghspd09
Copy link
Contributor

rapidjson::Writer::Flush was introduced 15th of March, 2017, without updating the version number (last version update is from 25th of August, 2016 from 1.0.2 to 1.1.0). It is therefore not possible to detect at build time if Writer::Flush is available.

Note that rapidjson::Writer::Flush simply calls rapidjson::OStreamWrapper::Flush.

The authors of rapidjson should really get their act together and bump the version when they change the API.

After reviewing the code, it appears that stream.Flush() is already implemented at line 381 of bench_ransTPC.cxx. There are no occurrences of writer.Flush() in the whole repository. This issue might be outdated or already resolved. Please confirm if further action is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants