-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Container snapshots and restore #6163
Comments
What are your thoughts about a |
I think it's definitely a possibility! There may be concerns about whether this is efficient enough (with respect to time and space). |
Docker should provide some snapshoting mechanism, but it has a design philosophy problem (they want them to stay ephemeral). |
Maybe LVM snapshots on the OH container/host? |
I tested btrfs snapshots succesfully and will be working on this feature. |
Thanks! I'm honestly not familiar enough with these options to comment on the technical approach, but I think if it's not too hard to prototype it'd be great to get a poc of this. |
Have you consider doing the simplest thing possible? Btrfs, loop device, lvm, those all require kernel privileges and support by the kernel. |
Also looking for a solution for revert, but cp does not work universally. Things like global package install won't work w/o some nasty hacks. |
I tested it using a loop device running inside a container in WSL2, which means it will work on any setup. |
What are your use cases? |
We could start with the user IMO, the feature would be immediately testable and useful. |
I agree, we should have this be user triggered at first. |
This comment has been minimized.
This comment has been minimized.
Can be tested here: #6441 Can we ask OH to add a restore button on the front end and to store the snapshot ID returned by |
What problem or use case are you trying to solve?
Somestimes OH modifications to the workspace are not as desired.
I noticed OH can undo file changes, but apparently only on single files and only 1 step back (?).
When we say "revert the changes", it's also not clear until which point we want OH to revert.
Having a feature to revert until a previous user input message would be nice.
Describe the UX of the solution you'd like
It would be nice to be able to edit any previous user message (just like with ChatGPT, Gemini, etc) and have OH automatically rollback the workspace to that point.
Do you have thoughts on the technical implementation?
docker commit
? Maybe too slow...The text was updated successfully, but these errors were encountered: