From f5ee42dcf9355d1cb39f438c3bb929a81e39192b Mon Sep 17 00:00:00 2001
From: Allan Otodi Opeto <103313919+AllanOXDi@users.noreply.github.com>
Date: Fri, 6 Sep 2024 13:09:02 +0300
Subject: [PATCH 1/7] remove mixed tag as a category

---
 .../QuickEditModal/EditBooleanMapModal.vue           |  6 +++---
 .../views/contentNodeFields/CategoryOptions.vue      | 12 ------------
 2 files changed, 3 insertions(+), 15 deletions(-)

diff --git a/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue b/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
index ad3ffbac7d..4f597b0036 100644
--- a/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
+++ b/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
@@ -2,7 +2,7 @@
 
   <KModal
     :title="title"
-    :submitText="$tr('saveAction')"
+    :submitText="error ? null : $tr('saveAction')"
     :cancelText="$tr('cancelAction')"
     data-test="edit-booleanMap-modal"
     @submit="handleSave"
@@ -26,9 +26,9 @@
       :inputHandler="(value) => { selectedValues = value }"
     ></slot>
 
-    <span v-if="error" class="red--text">
+    <!-- <span v-if="error" class="red--text">
       {{ error }}
-    </span>
+    </span> -->
   </KModal>
 
 </template>
diff --git a/contentcuration/contentcuration/frontend/shared/views/contentNodeFields/CategoryOptions.vue b/contentcuration/contentcuration/frontend/shared/views/contentNodeFields/CategoryOptions.vue
index 032a720873..2bf86abccc 100644
--- a/contentcuration/contentcuration/frontend/shared/views/contentNodeFields/CategoryOptions.vue
+++ b/contentcuration/contentcuration/frontend/shared/views/contentNodeFields/CategoryOptions.vue
@@ -157,14 +157,6 @@
       },
       autocompleteOptions() {
         const options = [...this.categoriesList];
-        if (this.expanded) {
-          // Just boolean maps can have indeterminate values
-          options.push({
-            value: MIXED,
-            text: this.$tr('mixedLabel'),
-            undeletable: true,
-          });
-        }
         return options;
       },
       autocompleteValues() {
@@ -216,9 +208,6 @@
         this.selected = {};
       },
       tooltipText(optionId) {
-        if (optionId === MIXED) {
-          return this.$tr('mixedLabel');
-        }
         const option = this.categoriesList.find(option => option.value === optionId);
         if (!option) {
           return '';
@@ -301,7 +290,6 @@
     },
     $trs: {
       noCategoryFoundText: 'Category not found',
-      mixedLabel: 'Mixed',
     },
   };
 

From 1aa3da847b9a8b729cf4304a4301054a915acb5a Mon Sep 17 00:00:00 2001
From: Allan Otodi Opeto <103313919+AllanOXDi@users.noreply.github.com>
Date: Fri, 6 Sep 2024 16:09:33 +0300
Subject: [PATCH 2/7] removes indeterminate state checkboxes

---
 .../components/QuickEditModal/EditBooleanMapModal.vue  | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue b/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
index 4f597b0036..7b393506d2 100644
--- a/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
+++ b/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
@@ -2,7 +2,7 @@
 
   <KModal
     :title="title"
-    :submitText="error ? null : $tr('saveAction')"
+    :submitText="canSave ? $tr('saveAction') : null"
     :cancelText="$tr('cancelAction')"
     data-test="edit-booleanMap-modal"
     @submit="handleSave"
@@ -99,6 +99,9 @@
       isTopicSelected() {
         return this.nodes.some(node => node.kind === ContentKindsNames.TOPIC);
       },
+      canSave() {
+        return Object.values(this.selectedValues).some(value => value.length > 0);
+      },
     },
     watch: {
       selectedValues() {
@@ -137,11 +140,6 @@
         }
       },
       async handleSave() {
-        this.validate();
-        if (this.error) {
-          return;
-        }
-
         await Promise.all(
           this.nodes.map(node => {
             const fieldValue = {};

From dc8789a241ccb79c99417580023ba8a0c1067f7f Mon Sep 17 00:00:00 2001
From: Allan Otodi Opeto <103313919+AllanOXDi@users.noreply.github.com>
Date: Fri, 6 Sep 2024 19:23:41 +0300
Subject: [PATCH 3/7] add helper text

---
 .../QuickEditModal/EditBooleanMapModal.vue     | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue b/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
index 7b393506d2..0080369dfe 100644
--- a/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
+++ b/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
@@ -2,7 +2,8 @@
 
   <KModal
     :title="title"
-    :submitText="canSave ? $tr('saveAction') : null"
+    :submitText="$tr('saveAction')"
+    :submitDisabled="!canSave"
     :cancelText="$tr('cancelAction')"
     data-test="edit-booleanMap-modal"
     @submit="handleSave"
@@ -11,13 +12,19 @@
     <p v-if="resourcesSelectedText.length > 0" data-test="resources-selected-message">
       {{ resourcesSelectedText }}
     </p>
+
+    <!-- Display helper text if categories are mixed -->
+    <p v-if="hasMixedCategories" data-test="additional-categories-description">
+      {{ $tr('addAdditionalCategoriesDescription') }}
+    </p>
+
     <template v-if="isDescendantsUpdatable && isTopicSelected">
       <KCheckbox
         :checked="updateDescendants"
         data-test="update-descendants-checkbox"
         :label="$tr('updateDescendantCheckbox')"
         @change="(value) => { updateDescendants = value }"
-      />
+        />
       <Divider />
     </template>
     <slot
@@ -102,6 +109,11 @@
       canSave() {
         return Object.values(this.selectedValues).some(value => value.length > 0);
       },
+      hasMixedCategories() {
+      const selectedNodes = this.nodes.filter(node => this.selectedValues[node.id]);
+      const categories = selectedNodes.map(node => node.categories || []);
+      return selectedNodes.length > 0 && new Set(categories.flat()).size > 1;
+     },
     },
     watch: {
       selectedValues() {
@@ -169,6 +181,8 @@
       cancelAction: 'Cancel',
       updateDescendantCheckbox:
         'Apply to all resources, folders, and subfolders contained within the selected folders.',
+      addAdditionalCategoriesDescription:
+        'You selected resources that have different categories. The categories you choose below will be added to all selected resources. This will not remove existing categories.',
     },
   };
 

From 86c0d78ad08ce242f4e724a98cadc76ea6373e25 Mon Sep 17 00:00:00 2001
From: Allan Otodi Opeto <103313919+AllanOXDi@users.noreply.github.com>
Date: Tue, 10 Sep 2024 23:01:55 +0300
Subject: [PATCH 4/7] fixes strings

---
 .../QuickEditModal/EditBooleanMapModal.vue    | 27 ++++++++++---------
 .../contentNodeFields/CategoryOptions.vue     | 22 +++++++++++++++
 2 files changed, 37 insertions(+), 12 deletions(-)

diff --git a/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue b/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
index 0080369dfe..c1e527737b 100644
--- a/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
+++ b/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
@@ -1,3 +1,4 @@
+<!-- eslint-disable kolibri/vue-no-undefined-string-uses -->
 <template>
 
   <KModal
@@ -12,19 +13,16 @@
     <p v-if="resourcesSelectedText.length > 0" data-test="resources-selected-message">
       {{ resourcesSelectedText }}
     </p>
-
-    <!-- Display helper text if categories are mixed -->
-    <p v-if="hasMixedCategories" data-test="additional-categories-description">
-      {{ $tr('addAdditionalCategoriesDescription') }}
+    <p v-if="hasMixedCategories" data-test="mixed-categories-message">
+      {{ hasMixedCategoriesMessage }}
     </p>
-
     <template v-if="isDescendantsUpdatable && isTopicSelected">
       <KCheckbox
         :checked="updateDescendants"
         data-test="update-descendants-checkbox"
         :label="$tr('updateDescendantCheckbox')"
         @change="(value) => { updateDescendants = value }"
-        />
+      />
       <Divider />
     </template>
     <slot
@@ -51,6 +49,7 @@
   import { mapGetters, mapActions } from 'vuex';
   import { ContentKindsNames } from 'shared/leUtils/ContentKinds';
   import { getInvalidText } from 'shared/utils/validation';
+  import commonStrings from 'shared/translator';
 
   export default {
     name: 'EditBooleanMapModal',
@@ -110,10 +109,16 @@
         return Object.values(this.selectedValues).some(value => value.length > 0);
       },
       hasMixedCategories() {
-      const selectedNodes = this.nodes.filter(node => this.selectedValues[node.id]);
-      const categories = selectedNodes.map(node => node.categories || []);
-      return selectedNodes.length > 0 && new Set(categories.flat()).size > 1;
-     },
+        const categories = this.nodes.map(node =>
+          Object.keys(node[this.field] || {}).filter(key => node[this.field][key])
+        );
+        const uniqueCategories = [...new Set(categories.flat())];
+        return uniqueCategories.length > 1;
+      },
+      hasMixedCategoriesMessage() {
+        // eslint-disable-next-line kolibri/vue-no-undefined-string-uses
+        return commonStrings.$tr('addAdditionalCatgoriesDescription');
+      },
     },
     watch: {
       selectedValues() {
@@ -181,8 +186,6 @@
       cancelAction: 'Cancel',
       updateDescendantCheckbox:
         'Apply to all resources, folders, and subfolders contained within the selected folders.',
-      addAdditionalCategoriesDescription:
-        'You selected resources that have different categories. The categories you choose below will be added to all selected resources. This will not remove existing categories.',
     },
   };
 
diff --git a/contentcuration/contentcuration/frontend/shared/views/contentNodeFields/CategoryOptions.vue b/contentcuration/contentcuration/frontend/shared/views/contentNodeFields/CategoryOptions.vue
index 2bf86abccc..447b074fd3 100644
--- a/contentcuration/contentcuration/frontend/shared/views/contentNodeFields/CategoryOptions.vue
+++ b/contentcuration/contentcuration/frontend/shared/views/contentNodeFields/CategoryOptions.vue
@@ -24,6 +24,10 @@
           :attach="attach"
           @click:clear="$nextTick(() => removeAll())"
         >
+          <!-- Display helper text if categories are mixed -->
+          <p v-if="hasMixedCategories" data-test="additional-categories-description">
+            {{ $tr('addAdditionalCategoriesDescription') }}
+          </p>
           <template #selection="data">
             <VTooltip bottom lazy>
               <template #activator="{ on, attrs }">
@@ -183,6 +187,22 @@
           option.text.toLowerCase().includes(searchQuery)
         );
       },
+      hasMixedCategories() {
+        // Fetch the selected categories for the given nodeIds
+        const selectedNodes = this.nodeIds.map(nodeId => {
+          // Find the category ID in the selected values
+          const categoryForNode = Object.entries(this.selected).find(([nodes]) =>
+            nodes.includes(nodeId)
+          );
+          return categoryForNode ? categoryForNode[0] : null; // Return the categoryId or null
+        });
+
+        const uniqueCategories = new Set(selectedNodes);
+        console.log('Selected Nodes:', selectedNodes); // Log selected nodes
+        console.log('Unique Categories:', uniqueCategories); // Log unique categories
+
+        return uniqueCategories.size > 1;
+      },
     },
     methods: {
       treeItemStyle(item) {
@@ -290,6 +310,8 @@
     },
     $trs: {
       noCategoryFoundText: 'Category not found',
+      addAdditionalCategoriesDescription:
+        'You selected resources that have different categories. The categories you choose below will be added to all selected resources. This will not remove existing categories.',
     },
   };
 

From cc6e7a0630eb88abcb40ba302af053711d306d84 Mon Sep 17 00:00:00 2001
From: Allan Otodi Opeto <103313919+AllanOXDi@users.noreply.github.com>
Date: Thu, 12 Sep 2024 23:50:54 +0300
Subject: [PATCH 5/7] code cleanup

---
 .../QuickEditModal/EditBooleanMapModal.vue    | 24 ++++++----
 .../contentNodeFields/CategoryOptions.vue     | 46 +------------------
 .../shared/views/form/ExpandableSelect.vue    |  9 +---
 3 files changed, 16 insertions(+), 63 deletions(-)

diff --git a/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue b/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
index c1e527737b..0fec536372 100644
--- a/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
+++ b/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
@@ -1,4 +1,4 @@
-<!-- eslint-disable kolibri/vue-no-undefined-string-uses -->
+
 <template>
 
   <KModal
@@ -98,7 +98,7 @@
       };
     },
     computed: {
-      ...mapGetters('contentNode', ['getContentNodes']),
+      ...mapGetters('contentNode', ['getContentNodes', 'getContentNode']),
       nodes() {
         return this.getContentNodes(this.nodeIds);
       },
@@ -109,11 +109,15 @@
         return Object.values(this.selectedValues).some(value => value.length > 0);
       },
       hasMixedCategories() {
-        const categories = this.nodes.map(node =>
-          Object.keys(node[this.field] || {}).filter(key => node[this.field][key])
-        );
-        const uniqueCategories = [...new Set(categories.flat())];
-        return uniqueCategories.length > 1;
+        const allSelectedCategories = new Set(Object.keys(this.selectedValues));
+        for (const categoryId of allSelectedCategories) {
+          const nodesWithThisCategory = this.selectedValues[categoryId].length;
+
+          if (nodesWithThisCategory < this.nodes.length) {
+            return true;
+          }
+        }
+        return false;
       },
       hasMixedCategoriesMessage() {
         // eslint-disable-next-line kolibri/vue-no-undefined-string-uses
@@ -160,10 +164,10 @@
         await Promise.all(
           this.nodes.map(node => {
             const fieldValue = {};
+            const currentNode = this.getContentNode(node.id);
             Object.entries(this.selectedValues).forEach(([key, value]) => {
-              if (value.includes(node.id)) {
-                fieldValue[key] = true;
-              }
+              const existingValue = currentNode[this.field][key] || false;
+              fieldValue[key] = existingValue || value.includes(node.id);
             });
             if (this.updateDescendants && node.kind === ContentKindsNames.TOPIC) {
               return this.updateContentNodeDescendants({
diff --git a/contentcuration/contentcuration/frontend/shared/views/contentNodeFields/CategoryOptions.vue b/contentcuration/contentcuration/frontend/shared/views/contentNodeFields/CategoryOptions.vue
index 447b074fd3..f6170a8b9a 100644
--- a/contentcuration/contentcuration/frontend/shared/views/contentNodeFields/CategoryOptions.vue
+++ b/contentcuration/contentcuration/frontend/shared/views/contentNodeFields/CategoryOptions.vue
@@ -5,7 +5,7 @@
       <template #default="{ attach, menuProps }">
         <VAutocomplete
           :value="autocompleteValues"
-          :items="autocompleteOptions"
+          :items="categoriesList"
           :searchInput.sync="categoryText"
           :label="translateMetadataString('category')"
           box
@@ -24,10 +24,6 @@
           :attach="attach"
           @click:clear="$nextTick(() => removeAll())"
         >
-          <!-- Display helper text if categories are mixed -->
-          <p v-if="hasMixedCategories" data-test="additional-categories-description">
-            {{ $tr('addAdditionalCategoriesDescription') }}
-          </p>
           <template #selection="data">
             <VTooltip bottom lazy>
               <template #activator="{ on, attrs }">
@@ -85,7 +81,6 @@
         :label="option.text"
         :style="treeItemStyle(option)"
         :checked="isSelected(option.value)"
-        :indeterminate="isCheckboxIndeterminate(option.value)"
         @change="onChange(option.value)"
       />
       <p
@@ -106,8 +101,6 @@
   import DropdownWrapper from 'shared/views/form/DropdownWrapper';
   import { constantsTranslationMixin, metadataTranslationMixin } from 'shared/mixins';
 
-  const MIXED = 'mixed';
-
   export default {
     name: 'CategoryOptions',
     components: { DropdownWrapper },
@@ -159,20 +152,10 @@
           this.$emit('input', value);
         },
       },
-      autocompleteOptions() {
-        const options = [...this.categoriesList];
-        return options;
-      },
       autocompleteValues() {
         const selectedValues = Object.entries(this.selected)
           .filter(entry => entry[1].length === this.nodeIds.length)
           .map(([key]) => key);
-        if (
-          this.expanded &&
-          Object.values(this.selected).some(value => value.length < this.nodeIds.length)
-        ) {
-          selectedValues.push(MIXED);
-        }
         return selectedValues;
       },
       nested() {
@@ -187,22 +170,6 @@
           option.text.toLowerCase().includes(searchQuery)
         );
       },
-      hasMixedCategories() {
-        // Fetch the selected categories for the given nodeIds
-        const selectedNodes = this.nodeIds.map(nodeId => {
-          // Find the category ID in the selected values
-          const categoryForNode = Object.entries(this.selected).find(([nodes]) =>
-            nodes.includes(nodeId)
-          );
-          return categoryForNode ? categoryForNode[0] : null; // Return the categoryId or null
-        });
-
-        const uniqueCategories = new Set(selectedNodes);
-        console.log('Selected Nodes:', selectedNodes); // Log selected nodes
-        console.log('Unique Categories:', uniqueCategories); // Log unique categories
-
-        return uniqueCategories.size > 1;
-      },
     },
     methods: {
       treeItemStyle(item) {
@@ -291,15 +258,6 @@
         });
         return nodeIds.size === this.nodeIds.length;
       },
-      isCheckboxIndeterminate(optionId) {
-        if (this.selected[optionId] && this.selected[optionId].length < this.nodeIds.length) {
-          return true;
-        }
-        return (
-          Object.keys(this.selected).some(selectedValue => selectedValue.startsWith(optionId)) &&
-          !this.isSelected(optionId)
-        );
-      },
       onChange(optionId) {
         if (this.isSelected(optionId)) {
           this.remove(optionId);
@@ -310,8 +268,6 @@
     },
     $trs: {
       noCategoryFoundText: 'Category not found',
-      addAdditionalCategoriesDescription:
-        'You selected resources that have different categories. The categories you choose below will be added to all selected resources. This will not remove existing categories.',
     },
   };
 
diff --git a/contentcuration/contentcuration/frontend/shared/views/form/ExpandableSelect.vue b/contentcuration/contentcuration/frontend/shared/views/form/ExpandableSelect.vue
index 127eeabd7a..cdeea8ee22 100644
--- a/contentcuration/contentcuration/frontend/shared/views/form/ExpandableSelect.vue
+++ b/contentcuration/contentcuration/frontend/shared/views/form/ExpandableSelect.vue
@@ -50,7 +50,6 @@
           :key="option.value"
           :label="option.text"
           :checked="isSelected(option.value)"
-          :indeterminate="isIndeterminate(option.value)"
           data-test="option-checkbox"
           @change="value => setOption(option.value, value)"
         />
@@ -188,12 +187,6 @@
         }
         return this.valueModel[value].length === this.availableItems.length;
       },
-      isIndeterminate(value) {
-        if (!this.valueModel[value]) {
-          return false;
-        }
-        return this.valueModel[value].length < this.availableItems.length;
-      },
       setOption(optionId, value) {
         if (value) {
           this.valueModel = {
@@ -216,4 +209,4 @@
     pointer-events: none;
     opacity: 0.5;
   }
-</style>
\ No newline at end of file
+</style>

From a57b9f11e2cbf3641addba20e4b6d8925aed01e0 Mon Sep 17 00:00:00 2001
From: Allan Otodi Opeto <103313919+AllanOXDi@users.noreply.github.com>
Date: Fri, 13 Sep 2024 00:23:22 +0300
Subject: [PATCH 6/7]  fixes failing test

---
 .../QuickEditModal/EditBooleanMapModal.vue    |  6 +++--
 .../__tests__/EditBooleanMapModal.spec.js     | 27 ++-----------------
 2 files changed, 6 insertions(+), 27 deletions(-)

diff --git a/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue b/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
index 0fec536372..79c123c4ca 100644
--- a/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
+++ b/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
@@ -162,13 +162,15 @@
       },
       async handleSave() {
         await Promise.all(
-          this.nodes.map(node => {
+          this.nodes.map(async node => {
             const fieldValue = {};
             const currentNode = this.getContentNode(node.id);
+
             Object.entries(this.selectedValues).forEach(([key, value]) => {
-              const existingValue = currentNode[this.field][key] || false;
+              const existingValue = currentNode[this.field]?.[key] || false;
               fieldValue[key] = existingValue || value.includes(node.id);
             });
+
             if (this.updateDescendants && node.kind === ContentKindsNames.TOPIC) {
               return this.updateContentNodeDescendants({
                 id: node.id,
diff --git a/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/__tests__/EditBooleanMapModal.spec.js b/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/__tests__/EditBooleanMapModal.spec.js
index e8a48355e1..428d41cad1 100644
--- a/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/__tests__/EditBooleanMapModal.spec.js
+++ b/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/__tests__/EditBooleanMapModal.spec.js
@@ -16,7 +16,6 @@ let generalActions;
 const CheckboxValue = {
   UNCHECKED: 'UNCHECKED',
   CHECKED: 'CHECKED',
-  INDETERMINATE: 'INDETERMINATE',
 };
 
 const { translateMetadataString } = metadataTranslationMixin.methods;
@@ -31,11 +30,9 @@ const getOptionsValues = wrapper => {
   const categories = {};
   const checkboxes = wrapper.findAll('[data-test="option-checkbox"]');
   checkboxes.wrappers.forEach(checkbox => {
-    const { label, checked, indeterminate } = checkbox.vm.$props || {};
+    const { label, checked } = checkbox.vm.$props || {};
     let value;
-    if (indeterminate) {
-      value = CheckboxValue.INDETERMINATE;
-    } else if (checked) {
+    if (checked) {
       value = CheckboxValue.CHECKED;
     } else {
       value = CheckboxValue.UNCHECKED;
@@ -182,26 +179,6 @@ describe('EditBooleanMapModal', () => {
         expect(dailyLifeValue).toBe(CheckboxValue.CHECKED);
         expect(foundationsValue).toBe(CheckboxValue.CHECKED);
       });
-
-      test('checkbox option should be indeterminate if not all nodes have the same options set', () => {
-        nodes['node1'].categories = {
-          [Categories.DAILY_LIFE]: true,
-          [Categories.FOUNDATIONS]: true,
-        };
-        nodes['node2'].categories = {
-          [Categories.DAILY_LIFE]: true,
-        };
-
-        const wrapper = makeWrapper({ nodeIds: ['node1', 'node2'] });
-
-        const optionsValues = getOptionsValues(wrapper);
-        const {
-          [Categories.DAILY_LIFE]: dailyLifeValue,
-          [Categories.FOUNDATIONS]: foundationsValue,
-        } = optionsValues;
-        expect(dailyLifeValue).toBe(CheckboxValue.CHECKED);
-        expect(foundationsValue).toBe(CheckboxValue.INDETERMINATE);
-      });
     });
   });
 

From b208530da2797d1d7ad1df23c91b8b39e4179b0b Mon Sep 17 00:00:00 2001
From: Allan Otodi Opeto <103313919+AllanOXDi@users.noreply.github.com>
Date: Fri, 13 Sep 2024 17:01:39 +0300
Subject: [PATCH 7/7]  minor clean up

---
 .../components/QuickEditModal/EditBooleanMapModal.vue          | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue b/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
index 79c123c4ca..8738fdc71f 100644
--- a/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
+++ b/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
@@ -31,9 +31,6 @@
       :inputHandler="(value) => { selectedValues = value }"
     ></slot>
 
-    <!-- <span v-if="error" class="red--text">
-      {{ error }}
-    </span> -->
   </KModal>
 
 </template>