Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add known_dims kwargs to TiffReader and DefaultReader #199

Closed
evamaxfield opened this issue Jan 31, 2021 · 2 comments
Closed

Add known_dims kwargs to TiffReader and DefaultReader #199

evamaxfield opened this issue Jan 31, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@evamaxfield
Copy link
Collaborator

Use Case

Please provide a use case to help us understand your request in context

We have a pretty decent guessing function for dimensions on DefaultReader and in many cases TiffReader will use the axes names from tifffile but would be nice to explicitely override when needed.

Solution

Please describe your ideal solution

Add known_dims parameter to TiffReader and DefaultReader similar to how it works in ArrayLikeReader.

Alternatives

Please describe any alternatives you've considered, even if you've dismissed them
@evamaxfield evamaxfield added the enhancement New feature or request label Jan 31, 2021
@evamaxfield evamaxfield added this to the Release 4.0 milestone Jan 31, 2021
@evamaxfield
Copy link
Collaborator Author

Also add known_channel_names to TiffReader here @toloudis ?

@evamaxfield evamaxfield removed this from the Release 4.0 milestone Feb 20, 2021
@evamaxfield evamaxfield added good first issue Good for newcomers help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Mar 4, 2021
@evamaxfield evamaxfield mentioned this issue Mar 30, 2021
Merged
4 tasks
@evamaxfield
Copy link
Collaborator Author

This was resolved by #244 but never closed 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@evamaxfield