New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wrapping div from live region #12

Open

AlmeroSteyn opened this issue Mar 20, 2019 · 0 comments · May be fixed by #16

Labels

good first issue

Owner

AlmeroSteyn commented Mar 20, 2019

Currently the Announcer component still has a needless wrapping div being rendered in the DOM:

      <div>
        <MessageBlock aria-live="assertive" message={assertiveMessage1} />
        <MessageBlock aria-live="assertive" message={assertiveMessage2} />
        <MessageBlock aria-live="polite" message={politeMessage1} />
        <MessageBlock aria-live="polite" message={politeMessage2} />
      </div>

This should be replace with a Fragment.

The text was updated successfully, but these errors were encountered:

AlmeroSteyn added the good first issue label

didoesdigital linked a pull request

that will close this issue

Replace needless wrapping div with Fragment #16

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment