Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor unit tests handling timers #525

Open
quentinderoubaix opened this issue Feb 26, 2024 · 0 comments
Open

Refactor unit tests handling timers #525

quentinderoubaix opened this issue Feb 26, 2024 · 0 comments
Labels
bug Something isn't working test
Milestone

Comments

@quentinderoubaix
Copy link
Contributor

Context
Some of our unit tests are creating and waiting for timers (cssTransition, promise) but are not using fake timers.
So not only do those tests take some time, but they were also flaky.
It became even worse after upgrade to vitest 1.3.1.

Implementation
Investigate the reason of this unreliability and remove the FIXMEs created in this commit
Potentially use vitest fake timers.

@quentinderoubaix quentinderoubaix added bug Something isn't working test labels Feb 26, 2024
@quentinderoubaix quentinderoubaix added this to the v1.0 milestone Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test
Projects
None yet
Development

No branches or pull requests

1 participant